Bug: Fixes x-model.fill when used with debounce #4103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Ok, that makes sense to me to just set that value directly instead of firing an event |
Contributor
|
Thank you, both! |
Contributor
Author
|
@calebporzio Yes, originally, it used the event, due to how the logic for modifiers like number and different elements was handled in a way that wasn't able to be easily set directly. |
This was referenced May 18, 2024
Open
Open
This was referenced May 21, 2024
Open
Open
Open
Open
Open
Open
This was referenced May 29, 2024
Open
Open
This was referenced May 31, 2024
This was referenced Jun 2, 2024
Open
Open
Open
Open
Open
This was referenced Sep 10, 2024
Open
Open
Open
Open
Open
Open
This was referenced Sep 17, 2024
Open
Open
Open
Open
Open
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
This was referenced Oct 1, 2024
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4102
due to how debounce influenced the handling of the fill event, the model would clear out the input value before the event would be handled.
demo here
This instead just directly uses the same methods to update the value. These methods hadn't existed before, which is why the event was used before.
This isn't amazing, since it does not use any real Events, since it's impossible to make a real Event with a target value, and I was aiming for a minimal impact change.
Test is included.